ref(appstore-connect): Remove setup steps asking for iTunes credentials [NATIVE-294] #29675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
relaxolotl
changed the title
relaxolotl
force-pushed
the
appconnect/stop-asking-for-itunes
branch
from
23ad1b8 to
9766676
Compare
relaxolotl
force-pushed
the
appconnect/stop-asking-for-credentials
branch
from
ee0bd43 to
68c31b3
Compare
Swatinem
approved these changes
Nov 2, 2021
Contributor
Swatinem
left a comment
Swatinem
left a comment
There was a problem hiding this comment.
❤️ I always love to see code being removed ;-)
Contributor
|
Curious to know what https://github.com/ai/size-limit actually measures, since I would expect all the removed code to show up there. |
Member
|
Thanks for doing this @relaxolotl <3 |
priscilawebdev
approved these changes
Nov 2, 2021
Member
priscilawebdev
left a comment
priscilawebdev
left a comment
There was a problem hiding this comment.
tested locally and it looks good to me
Contributor
Author
|
i think there are concerns about how to deploy this and the impact of this change's deployment. i'll try to get that sorted out tomorrow so that i can merge this without exploding something i haven't taken into account |
flub
pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Nov 4, 2021
ITunes credentials are no longer needed since getsentry/sentry#29675 did get merged. Co-authored-by: Floris Bruynooghe <flub@sentry.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes the full mile and removes the endpoints, backend code, and all front end code related to the steps that ask for iTunes credentials during the App Store Connect integration setup.
The new setup flow looks like so:
Existing integration
New integration
What this does not cover is the actual removal of iTunes credentials from symbol sources. That will come in a separate PR. This does start redacting and erasing those credentials if users are creating or updating their integrations.
related: #29531