ref(types): Use python 3.8 types in sentry.notifications
#29678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceorourke
reviewed
Oct 29, 2021
|
|
||
|
|
||
| def unsplit_key( | ||
| project: "Project", target_type: ActionTargetType, target_identifier: Optional[str] |
Member
There was a problem hiding this comment.
Is there a functional difference between Optional[str] and str | None?
Contributor
Author
There was a problem hiding this comment.
Optional[str] is equivalent to Union[str, None] which is equivalent to str | None.
ceorourke
approved these changes
Oct 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're on python 3.8 we have access to
|notation in types and no longer need to quote models. To create this PR, I addedfrom __future__ import annotationsto every file and letpyupgradeautomatically retype everything.