feat(slack): Allow team unlinking from slack in the UI #29682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
leeandher
commented
Nov 1, 2021
src/sentry/models/externalactor.py
Outdated
Comment on lines
43
to
44
| install.notify_remove_external_team(external_team=self, team=self.actor.resolve()) | ||
| install.remove_notification_settings(actor_id=self.actor_id, provider=self.provider) |
Member
Author
There was a problem hiding this comment.
@mgaeta So I was trying to do the noop for these functions but since I've built them into a separate mixin (src/sentry/integrations/notifications.py) and import it for the Slack integration (L69 in src/sentry/integrations/slack/integration.py on this PR), the noops are overriding the actual functions in the mixin file. Is there a way around this?
leeandher
force-pushed
the
slack-unlink/API-2206
branch
from
e99866d to
c8caa5a
Compare
mgaeta
reviewed
Nov 2, 2021
mgaeta
reviewed
Nov 2, 2021
mgaeta
approved these changes
Nov 2, 2021
leeandher
added a commit
that referenced
this pull request
Nov 5, 2021
See #29682 The previous PR included all the business logic for unlinking slack identities from the UI, but I reused an endpoint that was behind a feature flag I was opted in to, so I didn't notice it would 403 unless you had that feature (CODEOWNERS). The delete methods for external actor endpoints are now NOT feature flagged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See API-2206
This PR will allow for users to unlink teams from slack channels through the UI. If the channel is deleted, or they're unable to run
/sentry unlink teamfor any other reason, they'll still be able to go through the UI to remove the mapping.TODO
DEMOS
link.+.unlink.team.demo.mov
existing.ext-team.deletion.mov