feat(suspect-spans): Add rollout percentage option #29692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the rollout strategy requires specifying projects one by one because we were targeting specific projects during the initial rollout. As the rollout happens for more projects, we want to be able to roll it out for a percentage of projects at a time.
dashed
approved these changes
Nov 1, 2021
Zylphrex
deleted the
feat/add-rollout-percentage-option-for-suspect-spans
branch
dashed
reviewed
Nov 1, 2021
| # This is to enable the ingestion of suspect spans by project ids. | ||
| register("performance.suspect-spans-ingestion-projects", default={}) | ||
| # This is to enable the ingestion of suspect spans by project groups. | ||
| register("performance.suspect-spans-ingestion.rollout-rate", default=0) |
Member
There was a problem hiding this comment.
@Zylphrex would using FLAG_PRIORITIZE_DISK here be preferred?
Member
Author
There was a problem hiding this comment.
Hm... I'll double check 👍
Zylphrex
added a commit
to getsentry/snuba
that referenced
this pull request
Nov 3, 2021
Previously, suspect span ingestion can only be enabled on a per project basis. This change allows us to enable it for a percentage of projects at a time. See getsentry/getsentry#6531 and getsentry/sentry#29692 for the sentry PRs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the rollout strategy requires specifying projects one by one because
we were targeting specific projects during the initial rollout. As the rollout
happens for more projects, we want to be able to roll it out for a percentage of
projects at a time.