feat(dashboards): Allow functions in top events widget columns

[edwardgou-sentry]

Allow Dashboard Top Events widgets to add aggregate columns so that chart can be sorted by aggregates

[github-actions]

size-limit report

Path	Base Size (16e9dcd)	Current Size	Change
src/sentry/static/sentry/dist/entrypoints/app.js	52.76 KB	52.76 KB	-0.01% 🔽
src/sentry/static/sentry/dist/entrypoints/sentry.css	70.89 KB	70.89 KB	0%

[shruthilayaj]

So basically we're saying that the first aggregate field from the bottom up is the y-axis? Can we do something simpler instead like:
const fieldValue = fields[-1]
const columns = fields.slice(0, fields.length -1)

Would that work? because it's a single yAxis that is always required and populated for ton events?

[edwardgou-sentry]

Yes that would work! Updated to this, tested and cleaned up some other convoluted parts of code (don't recall why I made it so complicated lol). Also fixed a bug with default query field.

[shruthilayaj]

Something funky is going on when you save the widget/dashboard. Steps to replicate:

1. Add title and eps() as columns
2. count() as the yaxis
3. orderby count()
4. save widget and dashboard
5. open widget edit again, columns and y-axis aren't being saved as expected

[edwardgou-sentry]

Something funky is going on when you save the widget/dashboard. Steps to replicate:

1. Add title and eps() as columns
2. count() as the yaxis
3. orderby count()
4. save widget and dashboard
5. open widget edit again, columns and y-axis aren't being saved as expected

Good catch, I was able to replicated. Made an update to normalizeQueries for TOP_N to fix! Behaviour will be the same as TABLE now (it was removing some fields before).

[shruthilayaj]

Looks great! Loving the overall simplification!

[shruthilayaj]

nit: just combine with the if DisplayType.TABLE statement above