feat(trace-view): Update trace-view to use snql #29709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mostly straightforward, using datasets instead of `event.type` filters which cleans up the queries a bit, but otherwise the queries are mostly identical - Using a separate feature flag so I can start rolling out Discover SnQL without impacting performance too
wmak
commented
Nov 1, 2021
Comment on lines
+117
to
+125
| default_manager.add("organizations:performance-chart-interpolation", OrganizationFeature, True) | ||
| default_manager.add("organizations:performance-events-page", OrganizationFeature, True) | ||
| default_manager.add("organizations:performance-landing-widgets", OrganizationFeature, True) | ||
| default_manager.add("organizations:performance-mobile-vitals", OrganizationFeature, True) | ||
| default_manager.add("organizations:performance-ops-breakdown", OrganizationFeature) | ||
| default_manager.add("organizations:performance-suspect-spans-view", OrganizationFeature, True) | ||
| default_manager.add("organizations:performance-tag-explorer", OrganizationFeature, True) | ||
| default_manager.add("organizations:performance-tag-page", OrganizationFeature, True) | ||
| default_manager.add("organizations:performance-events-page", OrganizationFeature, True) | ||
| default_manager.add("organizations:performance-chart-interpolation", OrganizationFeature, True) | ||
| default_manager.add("organizations:performance-suspect-spans-view", OrganizationFeature, True) | ||
| default_manager.add("organizations:performance-use-snql", OrganizationFeature, True) |
Member
Author
There was a problem hiding this comment.
Sorted these which is why there's additional diffs
Zylphrex
reviewed
Nov 2, 2021
| ) | ||
| results = bulk_snql_query( | ||
| [transaction_query.get_snql_query(), error_query.get_snql_query()], | ||
| referrer="api.trace-view.get-events", |
Member
There was a problem hiding this comment.
Feel free to ignore this but using the same referrer for each of the bulk queries has been a pet peeve of mine since the two queries are different but we have no way of distinguishing between the two in the transaction.
Member
Author
There was a problem hiding this comment.
agreed, but the current bulk APIs don't support a way to provide >1 referrer yet. I have this mentally backlogged but let me create something in Jira
Zylphrex
approved these changes
Nov 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
event.typefilterswhich cleans up the queries a bit, but otherwise the queries are
mostly identical
without impacting performance too