From 88836521664091581e409d999fc4db2b76b9824a Mon Sep 17 00:00:00 2001
From: Shruthilaya <shruthilaya.jaganathan@sentry.io>
Date: Tue, 2 Nov 2021 07:16:55 -0400
Subject: [PATCH] fix(tags): Set filter transaction filter on conditions

Set transaction filter on conditions/query instead
of additionalConditions since that just adds a PREWHERE
clause on clickhouse and now we have two txn filters
and it's not performant.
---
 .../transactionSummary/transactionTags/index.tsx            | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/static/app/views/performance/transactionSummary/transactionTags/index.tsx b/static/app/views/performance/transactionSummary/transactionTags/index.tsx
index 5485db572d1a55..e5a89bda359f86 100644
--- a/static/app/views/performance/transactionSummary/transactionTags/index.tsx
+++ b/static/app/views/performance/transactionSummary/transactionTags/index.tsx
@@ -50,6 +50,10 @@ function getDocumentTitle(transactionName: string): string {
 function generateEventView(location: Location, transactionName: string): EventView {
   const query = decodeScalar(location.query.query, '');
   const conditions = new MutableSearch(query);
+  conditions
+    .setFilterValues('event.type', ['transaction'])
+    .setFilterValues('transaction', [transactionName]);
+
   const eventView = EventView.fromNewQueryWithLocation(
     {
       id: undefined,
@@ -62,8 +66,6 @@ function generateEventView(location: Location, transactionName: string): EventVi
     location
   );
 
-  eventView.additionalConditions.setFilterValues('event.type', ['transaction']);
-  eventView.additionalConditions.setFilterValues('transaction', [transactionName]);
   return eventView;
 }