fix(appstore-connect): Relax timeout for build fetching [NATIVE-294] #29724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
approved these changes
Nov 3, 2021
flub
approved these changes
Nov 3, 2021
| logger.debug(f"GET {full_url}") | ||
| with sentry_sdk.start_span(op="http", description="AppStoreConnect request"): | ||
| response = session.get(full_url, headers=headers, timeout=REQUEST_TIMEOUT) | ||
| response = session.get(full_url, headers=headers, timeout=REQUEST_TIMEOUT * 2) |
Contributor
There was a problem hiding this comment.
This is the only place in which we use REQUEST_TIMEOUT. Might as well change the value directly.
I'd also be tempted to change the line above to with sentry_sdk.start_transaction(op='http', description='AppStoreConnect request'): so that we get a searchable transaction which we can then see how long it usually takes, what the outliers are etc.
relaxolotl
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to cut down on instances of SENTRY-FOR-SENTRY-F0V.