ref(js): RuleListRow -> React.FC #29726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanpurkhiser
requested review from
a team and
scttcper
and removed request for
a team
priscilawebdev
approved these changes
Nov 3, 2021
matejminar
approved these changes
Nov 3, 2021
Member
matejminar
left a comment
matejminar
left a comment
There was a problem hiding this comment.
The conversion looks good.
Left a couple of optional suggestions while we are touching this file.
| </FlexCenter> | ||
|
|
||
| <FlexCenter> | ||
| {teamActor ? <ActorAvatar actor={teamActor} size={24} /> : '-'} |
Member
There was a problem hiding this comment.
We could use em dash / NotAvailable component.
| }} | ||
| size="small" | ||
| type="button" | ||
| aria-label={t('Show more')} |
Member
There was a problem hiding this comment.
Suggested change
| aria-label={t('Show more')} | |
| label={t('Show more')} |
Comment on lines
+281
to
+283
| <Tooltip title={t('Edit')}> | ||
| <Button | ||
| size="small" |
Member
There was a problem hiding this comment.
We could use the title prop on the button.
Also, let's add a label prop.
Comment on lines
+274
to
+279
| <Button | ||
| type="button" | ||
| icon={<IconDelete />} | ||
| size="small" | ||
| title={t('Delete')} | ||
| /> |
Member
There was a problem hiding this comment.
Should we set the label prop so that this button is a bit more accessible?
dashed
approved these changes
Nov 3, 2021
Member
Author
|
I'll go back and clean these up @matejminar. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.