Skip to content

fix(perf): Add empty state for list widget #29738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k-fish merged 4 commits into from
Nov 3, 2021
Merged

fix(perf): Add empty state for list widget #29738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a7e45b
fix(perf): Add empty state for list widget
k-fish Nov 3, 2021
4f3df22
Remove extra empty file
k-fish Nov 3, 2021
ea50065
Merge remote-tracking branch 'origin/master' into fix/perf-landing-v3…
k-fish Nov 3, 2021
0ec7436
Update for change with fields
k-fish Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions static/app/views/performance/landing/widgets/widgets/lineChartListWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {Location} from 'history';

import _EventsRequest from 'app/components/charts/eventsRequest';
import {getInterval} from 'app/components/charts/utils';
import EmptyStateWarning from 'app/components/emptyStateWarning';
import Link from 'app/components/links/link';
import Tooltip from 'app/components/tooltip';
import Truncate from 'app/components/truncate';
Expand Down Expand Up @@ -181,6 +182,9 @@ export function LineChartListWidget(props: Props) {
HeaderActions={provided => (
<ContainerActions isLoading={provided.widgetData.list?.isLoading} />
)}
EmptyComponent={() => (
<StyledEmptyStateWarning small>{t('No results')}</StyledEmptyStateWarning>
)}
Queries={Queries}
Visualizations={[
{
Expand Down Expand Up @@ -319,3 +323,8 @@ const StyledIconClose = styled(IconClose)`
color: ${p => p.theme.gray300};
}
`;

const StyledEmptyStateWarning = styled(EmptyStateWarning)`
min-height: 300px;
justify-content: center;
`;
42 changes: 42 additions & 0 deletions tests/js/spec/views/performance/landing/widgets/widgetContainer.spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,48 @@ describe('Performance > Widgets > WidgetContainer', function () {
);
});

it('Most slow frames widget', async function () {
const data = initializeData();

const wrapper = mountWithTheme(
<WrappedComponent
data={data}
defaultChartSetting={PerformanceWidgetSetting.MOST_SLOW_FRAMES}
/>,
data.routerContext
);
await tick();
wrapper.update();

expect(wrapper.find('div[data-test-id="performance-widget-title"]').text()).toEqual(
'Most Slow Frames'
);

expect(eventsV2Mock).toHaveBeenCalledTimes(1);
expect(eventsV2Mock).toHaveBeenNthCalledWith(
1,
expect.anything(),
expect.objectContaining({
query: expect.objectContaining({
environment: [],
field: [
'transaction',
'project.id',
'epm()',
'p75(measurements.frames_slow_rate)',
],
per_page: 3,
project: [],
query: 'epm():>0.01 p75(measurements.frames_slow_rate):>0',
sort: '-p75(measurements.frames_slow_rate)',
statsPeriod: '14d',
}),
})
);

expect(wrapper.find('div[data-test-id="empty-message"]').exists()).toBe(true);
});

it('Able to change widget type from menu', async function () {
const data = initializeData();

Expand Down