fix(workflow): Catch errors on team insights discover query #29748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if a team has too many projects, it will cause a 502 error
markstory
approved these changes
Nov 4, 2021
Member
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
Eventually will the source of the 502s be fixed?
matejminar
approved these changes
Nov 4, 2021
| {context: routerContext} | ||
| ); | ||
|
|
||
| await waitForElementToBeRemoved(screen.queryByTestId('loading-indicator')); |
Member
There was a problem hiding this comment.
We can use this instead (and if it fails, then we probably do not need the line at all)
Suggested change
| await waitForElementToBeRemoved(screen.queryByTestId('loading-indicator')); | |
| await waitForElementToBeRemoved(screen.getByTestId('loading-indicator')); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a team has too many projects, it will cause a 502 error. For now, show an error banner.