fix(suspect-spans): Span frequency should never exceed 100% #29754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the use of `count_unique(id)` to compute the number of transactions that contain the span, and that it is an approximation, it is possible that we will see some frequency values exceeding 100%. This clips the frequency value so that this never happens.
k-fish
approved these changes
Nov 4, 2021
Member
k-fish
left a comment
k-fish
left a comment
There was a problem hiding this comment.
I'm guessing that your note with count_unique(id) means you've confirmed that's the cause? if so then 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the use of
count_unique(id)to compute the number of transactionsthat contain the span, and that it is an approximation, it is possible that we
will see some frequency values exceeding 100%. This clips the frequency value so
that this never happens.