fix(notifications): Get default settings in where_should_be_participating
#29757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wedamija
approved these changes
Nov 3, 2021
| notification_settings = { | ||
| self.user: { | ||
| NotificationScopeType.USER: { | ||
| ExternalProviders.SLACK: NotificationSettingOptionValues.NEVER |
Member
There was a problem hiding this comment.
If this is ALWAYS for slack do we expect email to also be ALWAYS? I assume yes but just want to confirm.
Contributor
Author
There was a problem hiding this comment.
Yup it'd be ALWAYS I'll add a test.
added 2 commits
November 3, 2021 15:44
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an alert rule is triggered and we've determined eligible notification recipients, we check each of those recipient's NotificationSettings to filter to the correct provider (e.g. Slack, Email).
The way the NotificationSettings are saved in the DB is "a little funny". A missing row can be interpreted as "read the next level up". For example if there is not project-specific row, we should check the project-independent row. If there is no project-independent row, fall back to the repo's default.
The code that does that last level of falling back was broken. This PR fixes it by first creating a mapping with the default settings first and then overriding the values from the DB.
@wedamija Found this with an incredible bout of debugging.