Skip to content

Conversation

@k-fish
Copy link
Member

@k-fish k-fish commented Nov 4, 2021

Summary

The additional types were causing provided to not show a type error as it was implicitly any.
This was causing an error since provide.eventView is no longer passed.

Other

  • Small type fixes and filling in the EventRequest props

The additional types were causing provided to not show a type error as it was implicitly any.
This was causing an error since provide.eventView is no longer passed.
@k-fish k-fish requested a review from a team November 4, 2021 13:11
@k-fish k-fish enabled auto-merge (squash) November 4, 2021 13:28
Copy link
Member

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-fish k-fish merged commit e87b3af into master Nov 4, 2021
@k-fish k-fish deleted the fix/perf-landing-v3-type-implicit branch November 4, 2021 16:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants