feat: Add API to identify available permissions #29789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will be utilized when building a configuration form in admin, and makes use of the currently unused configurable list of permissions.
Member
Author
|
@wedamija found a use for it :) |
markstory
approved these changes
Nov 4, 2021
Member
Author
|
thought: if permisisons are superuser only, should this return empty list when user is missing is_superuser? my thoughts are: meh who cares |
wedamija
approved these changes
Nov 4, 2021
Member
wedamija
left a comment
wedamija
left a comment
There was a problem hiding this comment.
It's probably not that big of a deal, but since this endpoint is intended for use only by superusers should we just restrict it and 403/404 if they don't have it?
Member
Author
|
@wedamija if we do we will likely want to change that in quite a few places. I'm not opposed but also not concerneda bout risk |
Member
Author
|
Will revisit perms issue as a whole later |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be utilized when building a configuration form in admin, and makes use of the currently unused configurable list of permissions.