Skip to content

fix(perf): Fix vitalWidget request and bar #29795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k-fish merged 1 commit into from
Nov 4, 2021
Merged

fix(perf): Fix vitalWidget request and bar #29795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions static/app/views/performance/landing/widgets/widgets/vitalWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export function VitalWidget(props: Props) {
currentSeriesNames={[field]}
includePrevious={false}
partial={false}
includeTransformedData={false}
includeTransformedData
query={_eventView.getQueryWithAdditionalConditions()}
interval={getInterval(
{
Expand Down Expand Up @@ -242,17 +242,17 @@ export function VitalWidget(props: Props) {
<GrowLink to={target}>
<Truncate value={transaction} maxLength={40} />
</GrowLink>
<RightAlignedCell>
<VitalBarCell>
<VitalBar
isLoading={provided.widgetData.list?.isLoading}
vital={settingToVital[props.chartSetting]}
data={data}
showBar
showDurationDetail={false}
showDetail={false}
barHeight={20}
barHeight={24}
/>
</RightAlignedCell>
</VitalBarCell>
<CloseContainer>
<StyledIconClose
onClick={() => {
Expand Down Expand Up @@ -293,6 +293,10 @@ function getVitalDataForListItem(listItem: TableDataRow) {
return vitalData;
}

const VitalBarCell = styled(RightAlignedCell)`
width: 120px;
margin-right: ${space(1)};
`;
const EventsRequest = withApi(_EventsRequest);
const Subtitle = styled('span')`
color: ${p => p.theme.gray300};
Expand Down
6 changes: 2 additions & 4 deletions static/app/views/performance/vitalDetail/vitalChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,10 +327,8 @@ function __VitalChart(props: _VitalChartProps) {

const results = _results.filter(r => !!fieldToVital(r.seriesName));

const {smoothedResults} = transformEventStatsSmoothed(results);

const smoothedSeries = smoothedResults
? smoothedResults.map(({seriesName, ...rest}) => {
const smoothedSeries = results?.length
? results.map(({seriesName, ...rest}) => {
return {
seriesName: fieldToVital(seriesName) || 'count',
...rest,
Expand Down