Skip to content

ref(js): Convert CreateTeamModal to a FC #29796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evanpurkhiser merged 1 commit into from
Nov 5, 2021
Merged

ref(js): Convert CreateTeamModal to a FC #29796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 31 additions & 38 deletions static/app/components/modals/createTeamModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,52 +1,45 @@
import {Component, Fragment} from 'react';
import {Fragment} from 'react';

import {ModalRenderProps} from 'app/actionCreators/modal';
import {createTeam} from 'app/actionCreators/teams';
import {Client} from 'app/api';
import CreateTeamForm from 'app/components/teams/createTeamForm';
import {t} from 'app/locale';
import {Organization, Team} from 'app/types';
import withApi from 'app/utils/withApi';
import useApi from 'app/utils/useApi';

type Props = {
api: Client;
type Props = ModalRenderProps & {
organization: Organization;
onClose?: (team: Team) => void;
} & ModalRenderProps;

class CreateTeamModal extends Component<Props> {
handleSubmit = (data: {slug: string}, onSuccess: Function, onError: Function) => {
const {organization, api} = this.props;
createTeam(api, data, {orgId: organization.slug})
.then((resp: Team) => {
this.handleSuccess(resp);
onSuccess(resp);
})
.catch((err: Error) => {
onError(err);
});
};

handleSuccess(team: Team) {
if (this.props.onClose) {
this.props.onClose(team);
};

function CreateTeamModal({Body, Header, ...props}: Props) {
const {onClose, closeModal, organization} = props;
Comment on lines +15 to +16
Copy link
Member

@matejminar matejminar Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be destructured in one place?

Copy link
Member Author

@evanpurkhiser evanpurkhiser Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We pass down the props, which is why I did this.

const api = useApi();

async function handleSubmit(
data: {slug: string},
onSuccess: Function,
onError: Function
) {
try {
const team: Team = await createTeam(api, data, {orgId: organization.slug});

closeModal();
onClose?.(team);
onSuccess(team);
} catch (err) {
onError(err);
}

this.props.closeModal();
}

render() {
const {Body, Header, ...props} = this.props;

return (
<Fragment>
<Header closeButton>{t('Create Team')}</Header>
<Body>
<CreateTeamForm {...props} onSubmit={this.handleSubmit} />
</Body>
</Fragment>
);
}
return (
<Fragment>
<Header closeButton>{t('Create Team')}</Header>
<Body>
<CreateTeamForm {...props} onSubmit={handleSubmit} />
</Body>
</Fragment>
);
}

export default withApi(CreateTeamModal);
export default CreateTeamModal;