Skip to content

fix(dashboards): filter out empty entries in timeseriesResult before passing to children #29800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
edwardgou-sentry merged 1 commit into from
Nov 4, 2021
Merged

fix(dashboards): filter out empty entries in timeseriesResult before passing to children #29800

edwardgou-sentry merged 1 commit into from
Nov 4, 2021

Conversation

@edwardgou-sentry
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry commented Nov 4, 2021

Child nodes of widgetQueries expect that timeseriesResult array prop has no undefined, null, etc entries.
This fixes cases where timeseriesResult may have empty entries by filtering out those entries before passing to child nodes.

@edwardgou-sentry edwardgou-sentry requested a review from a team November 4, 2021 21:40
@edwardgou-sentry edwardgou-sentry enabled auto-merge (squash) November 4, 2021 21:48
@edwardgou-sentry edwardgou-sentry merged commit 6705eab into master Nov 4, 2021
@edwardgou-sentry edwardgou-sentry deleted the fix/widget-query-filter-empty-timeseries branch November 4, 2021 22:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@k-fish k-fish k-fish approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edwardgou-sentry @k-fish