Handle GroupTagKey and GroupTagValue when merging issues #2984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/sentry/tasks/merge.py
Outdated
Contributor
There was a problem hiding this comment.
I'm confused. Those two branches look the same to me.
Contributor
There was a problem hiding this comment.
ignore me. values_seen vs times_seen.
dcramer
force-pushed
the
fix-merge
branch
2 times, most recently
from
82a90a6 to
7ce72a4
Compare
tests/sentry/tasks/test_merge.py
Outdated
Contributor
There was a problem hiding this comment.
I was going to do this, but to assert against the regression, we need different GroupTagKey objects with different keys.
Current coverage is
|
This reverts commit ef9986a. Fixes SENTRY-10F
Contributor
|
I'm commandeering this and adding more test cases to prevent a regression here again |
mattrobenolt
added a commit
that referenced
this pull request
Apr 5, 2016
Handle GroupTagKey and GroupTagValue when merging issues Conflicts: src/sentry/tasks/merge.py tests/sentry/tasks/test_merge.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-2804
This reverts commit ef9986a.
@getsentry/api