fix(perf): Fix issues widget for frontend view #29845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frontend view adds transaction.op as an additional condition, but this needs to be removed when searching for related issues, since it's not a type available on errors.
shruthilayaj
approved these changes
Nov 8, 2021
Member
shruthilayaj
left a comment
shruthilayaj
left a comment
There was a problem hiding this comment.
This change looks good for the Frontend (Pageload) tab but on Frontend (Other) it looks like there's this condition !transaction.op:pageload that isn't being removed by the mutable search and it shows the empty state of "no search results". Should !transaction.op:pageload filter also be removed?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The frontend view adds transaction.op as an additional condition, but this needs to be removed when searching for related issues, since it's not a type available on errors.
Other: