chore(reports): Add retry and acks_late to tasks #29853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceorourke
commented
Nov 8, 2021
src/sentry/tasks/reports.py
Outdated
|
|
||
|
|
||
| @instrumented_task(name="sentry.tasks.reports.prepare_reports", queue="reports.prepare") | ||
| @retry() |
Member
Author
There was a problem hiding this comment.
Honestly I'd prefer to do one at a time so I can actually see what's needed if just one works, but given the week long turnaround with this I thought I'd just go ham. This article suggests it's okay to do: https://docs.celeryproject.org/en/stable/faq.html#faq-acks-late-vs-retry
but I'd be okay with doing just acks_late in this PR and adding retries later if that doesn't work.
Member
There was a problem hiding this comment.
You should include a max_retries for the instrumented_task decorator or celery will always retry which can amplify the impacts of an outage as tasks will fail, respawn and then fail in a loop. We often use 5 as our retry limit.
markstory
approved these changes
Nov 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some weekly reports are not getting sent to customers and this is an attempt to help the tasks run smoothly so that the reports send.
I had added some logging here and here that unfortunately wasn't very helpful, so I am hoping that adding
acks_lateandmax_retriesto the reports tasks will help.