Skip to content

test(ts): Cleanup typing on the mock api #29860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
evanpurkhiser merged 1 commit into from
Nov 9, 2021
Merged

test(ts): Cleanup typing on the mock api #29860

evanpurkhiser merged 1 commit into from
Nov 9, 2021

Conversation

@evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented Nov 9, 2021

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team November 9, 2021 00:31
@evanpurkhiser evanpurkhiser enabled auto-merge (squash) November 9, 2021 01:01
davidenwang
davidenwang approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@davidenwang davidenwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@evanpurkhiser evanpurkhiser merged commit 345e1ec into master Nov 9, 2021
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/test-ts-cleanup-typing-on-the-mock-api branch November 9, 2021 02:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@davidenwang davidenwang davidenwang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evanpurkhiser @davidenwang