Skip to content

Don't require SMTP keys to be set when backend doesn't require them #2991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattrobenolt merged 1 commit into from
Apr 5, 2016
Merged

Don't require SMTP keys to be set when backend doesn't require them #2991

mattrobenolt merged 1 commit into from
Apr 5, 2016
+29 −12

Conversation

@mattrobenolt
Copy link
Contributor

@mattrobenolt mattrobenolt commented Apr 5, 2016

Fixes GH-2970

@getsentry/infrastructure @tkaemming

@codecov-io
Copy link

codecov-io commented Apr 5, 2016

Current coverage is 82.74%

Merging #2991 into master will decrease coverage by -0.43% as of 7ef6c20

@@            master   #2991   diff @@
======================================
  Files          920     920       
  Stmts        35996   36005     +9
  Branches         0       0       
  Methods          0               
======================================
- Hit          29941   29791   -150
  Partial          0       0       
- Missed        6055    6214   +159

Review entire Coverage Diff as of 7ef6c20

Powered by Codecov. Updated on successful CI builds.

@tkaemming
Copy link
Contributor

tkaemming commented Apr 5, 2016

👍

@mattrobenolt mattrobenolt merged commit aaca3fc into master Apr 5, 2016
@mattrobenolt mattrobenolt deleted the smtp branch April 5, 2016 22:37
mattrobenolt added a commit that referenced this pull request Apr 5, 2016
@mattrobenolt
Merge pull request #2991 from getsentry/smtp
425586f 
Don't require SMTP keys to be set when backend doesn't require them
@mattrobenolt mattrobenolt mentioned this pull request Apr 7, 2016
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When using a non-smtp based backend, you may get endless loop of installation wizard prompt

4 participants

@mattrobenolt @codecov-io @tkaemming