Fail to render event_details when there's more than one UserReport for an event id

[mattrobenolt]

Fixes SENTRY-16W

@getsentry/infrastructure

[codecov-io]

Current coverage is 82.49%

Merging #3140 into master will increase coverage by +<.01%

1. File ...y/models/eventtag.py (not in diff) was modified. more
   • Misses 0
   • Partials 0
   • Hits -1

@@             master      #3140   diff @@
==========================================
  Files           941        941          
  Lines         37018      37033    +15   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          30534      30549    +15   
  Misses         6484       6484          
  Partials          0          0          

Powered by Codecov. Last updated by 1c5ae57...204233d

[JTCunning]

LGTM

[mattrobenolt]

@ckj brought up a good point. Why were there two UserReports here in the first place. There should only ever be one.

[dcramer]

null unique constraint?

[mattrobenolt]

null unique constraint?

Why a null? We can do a UNIQUE on (project_id, event_id) here without an issue. I wasn't sure if this was an oversight or an explicit reason to be done this way.

Turns out, a user was poking around with the client and explicitly did this. So I don't think we need to be overly defensive here, but it did break the app then to view the event details page. So we should either reject the input, override an existing entry with create_or_update, or just ignore multiple records and choose the latest (what I proposed here before I fully understood what was going on).

[dcramer]

lgtm

[mattrobenolt]

@dcramer Just updated this to use a UNIQUE constraint instead, and the API now updates an existing one if found, rather than just erroring out all over the place.

[mitsuhiko]

@mattrobenolt we should merge this. there are already so many migration PRs pending and cooking and this one is basically already signed off.

[mattrobenolt]

Yeah, gonna rebase, recreate migration, and merge this now.