fix(metrics): adjust regex to avoid exponential backtracking #34881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust regex to avoid exponential backtracking when fed a string containing a lot of underscores.
The
\wtoken is effectively[a-zA-Z0-9_]so I've excluded the explicit_in the regex as well.The original
FIELD_REGEXhad 3 capture groups, but I don't think they are actually needed. I condensed this down to two. Could I have the reviewer double check that for me? 🙂FIELD_REGEX: (left: old regex | right: new regex)