Thread and Mixed Platform Support #3612
Conversation
| def to_python(cls, data): | ||
| threads = [] | ||
|
|
||
| for thread in data.get('list') or (): |
There was a problem hiding this comment.
Can we call this values instead of list
There was a problem hiding this comment.
I was considering it. I just want to discourage people to send this as a list.
mitsuhiko
force-pushed
the
feature/new-crash-report
branch
2 times, most recently
from
ceb069e
to
b73b7e6
Compare
mitsuhiko
force-pushed
the
feature/new-crash-report
branch
2 times, most recently
from
4d22d7b
to
680c296
Compare
| @@ -326,8 +326,6 @@ def normalize(self): | |||
| except Exception: | |||
| # XXX: we should consider logging this. | |||
| pass | |||
| else: | |||
| data['tags'].extend(inst.iter_tags()) | |||
There was a problem hiding this comment.
assuming this was moved somewhere, but im not familiar with the code so just checking it was intentional
There was a problem hiding this comment.
Yes, this was accidentally left in which meant that tags in some circumstances were recorded twice.
|
I think we should improve some visuals here, but we could do that after merging. I am a bit concerned about the overall event size. Do we know the rough size of a real-world payload with threads? |
mitsuhiko
force-pushed
the
feature/new-crash-report
branch
from
8262693
to
d84b7dc
Compare
|
I refactored the thread and exception rendering so that we can implement what we have in the mockup. I did not fully implement the mockup yet because I don't have the right component available to do the thread selector as @ckj had it but I think this might be a reasonable start. |
mitsuhiko
changed the title
|
As far as I'm concerned this is ready for merging. |
|
I think this is good, though I'm not sure the pill solution is the best for this (as its semi unstructured and variable width). I think it'd also be nice to keep the entire thread title available (rather than just the short title) outside of the select-open view. If the screenshots are up to date it also looks like there's a bit of a margin issue. I think we can deal with these when we implement the sidebar version. |
mitsuhiko
force-pushed
the
feature/new-crash-report
branch
from
6afe9cf
to
d6bac12
Compare
|
Closing this for #3634 which has all the things now. |
This is a work in progress pull request that implements mixed platforms on a frame by frame basis as well as support for handling multiple threads and stacktraces. Among other things it also adds the baseline support for the new flexible symbolication support which is in #3634.
New Thread Rendering
Stacktrace only:
Exception:
## Dropdown
## Other thingsThe tag selector also uses lozenges now: