fix(derive_code_mappings): Do not report error if installation is not found #42487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… found
This only handles the case when the Github App installation is not found:
```
{"message":"Not Found","documentation_url":"https://docs.github.com/rest/reference/apps#create-an-installation-access-token-for-an-app"}
```
Partially fixes [SENTRY-WSE](https://sentry.io/organizations/sentry/issues/3788707673/?project=1&query=is%3Aunresolved+assigned%3A%5Bme%2C+none%5D+timesSeen%3A%3E10+derive&referrer=issue-stream&sort=freq&statsPeriod=2h)
armenzg
added this to the Post-GA fixes and improvements for derived code mappings milestone
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Dec 20, 2022
| @@ -71,6 +73,12 @@ def derive_code_mappings( | |||
| try: | |||
| with lock.acquire(): | |||
| trees = installation.get_trees_for_org() | |||
| except ApiError as error: | |||
There was a problem hiding this comment.
When we call get_trees_for_org, we need to request access tokens from the GH installation for that org.
If the admins, uninstalled the Sentry GH App we would then not be able to request tokens anymore.
If you load the Sentry issue you will see that HTTPError 404 Client Error: Not Found for url: https://api.github.com/app/installations/<some_id>/access_tokens is raised at the bottom of the stack trace.
| json_data: JSONData = error.json | ||
| msg: str = json_data.get("message") | ||
| if msg == "Not Found": | ||
| logger.warning("The org has uninstalled the Sentry App.") |
There was a problem hiding this comment.
We should stop raising errors when there's nothing we can do about it.
scttcper
approved these changes
Dec 20, 2022
armenzg
added a commit
that referenced
this pull request
Dec 21, 2022
In #42487 we introduced a regression of not reporting other kinds of API Errors to Sentry
armenzg
added a commit
that referenced
this pull request
Dec 21, 2022
In #42487 we introduced a regression of not reporting other kinds of API Errors to Sentry. There's also some other minor fixes. Fixes [SENTRY-XPC](https://sentry.io/organizations/sentry/issues/3820120776). Fixes [SENTRY-XPW](https://sentry.io/organizations/sentry/issues/3825762675).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only handles the case when the Github App installation is not found:
Partially fixes SENTRY-WSE