Skip to content

Conversation

@tkaemming
Copy link
Contributor

No description provided.

@getsentry-bot
Copy link
Contributor

getsentry-bot commented Oct 31, 2016

✅ Congrats.
You need to update CHANGES due to the size of this PR
2 Warnings
⚠️ Changes require @getsentry/security sign-off
⚠️ Big PR – consider splitting it up into multiple changesets

Security concerns found

  • src/sentry/utils/email.py
  • tests/acceptance/test_emails.py
  • tests/sentry/utils/email/tests.py

Generated by 🚫 danger

@tkaemming tkaemming force-pushed the report-responsive branch 2 times, most recently from 4ffbc0b to e7cb6a5 Compare November 1, 2016 00:13
@tkaemming
Copy link
Contributor Author

img_1733

img_1734

img_1735

img_1736

@tkaemming
Copy link
Contributor Author

I tried to add the mobile size to Percy but I am too lazy (and/or dumb) to figure it out quickly so I didn't. It'd probably be pretty useful here though since nobody is going to look at these until they're broken.

Copy link
Member

@ckj ckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this. Looks great. 🤘

@tkaemming tkaemming merged commit dda6615 into master Nov 1, 2016
@tkaemming tkaemming deleted the report-responsive branch November 1, 2016 20:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants