ref(outcomes) Add methods to build outcomes queries without django #45730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query builder for outcomes is coupled to Django's QueryDict object. Adding a simple python primitive based API will make building outcomes queries simpler as you don't need to build more intermerdiary objects. If folks are ok with this approach, I'll convert the other outcomes queries in getsentry + sentry to use the new factory methods and then make `__init__` not rely on `QueryDict` anymore.
github-actions
bot
added
the
Scope: Backend
JoshFerge
approved these changes
Mar 13, 2023
One idea I've had for this is that top-level modules ( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query builder for outcomes is coupled to Django's QueryDict object. Adding a simple python primitive based API will make building outcomes queries simpler as you don't need to build more intermerdiary objects.
If folks are ok with this approach, I'll convert the other outcomes queries in getsentry + sentry to use the new factory methods and then make
__init__not rely onQueryDictanymore.