feat(onboarding): Add view sample error button new design - [TET-778] #45820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
priscilawebdev
changed the base branch from
master
to
priscila/feat/onboarding-add-feature-flag-for-controlling-view-sample-error-button
github-actions
bot
added
the
Scope: Backend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Base automatically changed from
priscila/feat/onboarding-add-feature-flag-for-controlling-view-sample-error-button
to
master
March 15, 2023 09:28
…ror-button-new-design
priscilawebdev
removed
the
Scope: Backend
iambriccardo
approved these changes
Mar 15, 2023
priscilawebdev
deleted the
priscila/ref/onboarding-add-view-sample-error-button-new-design
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we want to do an A/B test checking how many times people click on the "View Sample Error" button, we are adding this button behind the feature flag
onboarding-heartbeat-footer-with-view-sample-errorand it is going to be shown only if users haven't yet sent a first error.THis PR also adds more analytics code for this button so we can track in amplitude.