Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict file downloads to Project #49680

Merged
merged 1 commit into from
May 24, 2023
Merged

Restrict file downloads to Project #49680

merged 1 commit into from
May 24, 2023

Conversation

Swatinem
Copy link
Member

The debug_files and artifact_lookup endpoint are now restricting file downloads to the specific project according to the route parameters.

The `debug_files` and `artifact_lookup` endpoint are now restricting file downloads to the specific project according to the route parameters.
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #49680 (a3ab309) into master (a72576a) will decrease coverage by 0.01%.
The diff coverage is 95.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #49680      +/-   ##
==========================================
- Coverage   80.97%   80.97%   -0.01%     
==========================================
  Files        4821     4821              
  Lines      202197   202205       +8     
  Branches    11325    11325              
==========================================
+ Hits       163724   163727       +3     
- Misses      38221    38226       +5     
  Partials      252      252              
Impacted Files Coverage Δ
src/sentry/api/endpoints/debug_files.py 85.57% <50.00%> (ø)
src/sentry/api/endpoints/artifact_lookup.py 90.00% <100.00%> (+0.65%) ⬆️

... and 5 files with indirect coverage changes

@Swatinem Swatinem merged commit e932b15 into master May 24, 2023
55 checks passed
@Swatinem Swatinem deleted the swatinem/file-downloads branch May 24, 2023 14:47
volokluev pushed a commit that referenced this pull request May 30, 2023
The `debug_files` and `artifact_lookup` endpoint are now restricting
file downloads to the specific project according to the route
parameters.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants