Skip to content

Conversation

@tkaemming
Copy link
Contributor

Fixes GH-4972.

'url',
'event.timestamp'])
'event.timestamp'
'timesSeen',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure what is considered stylistically consistent/preferred here at this point.

active_at_to=None, active_at_to_inclusive=True,
times_seen=None,
times_seen_lower=None, times_seen_lower_inclusive=True,
times_seen_upper=None, times_seen_upper_inclusive=True,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love this

Copy link
Contributor

@mattrobenolt mattrobenolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@tkaemming tkaemming force-pushed the absolute-count-search branch from f1931dc to 6603610 Compare March 1, 2017 22:10
@tkaemming tkaemming merged commit 7c40b7b into master Mar 1, 2017
@tkaemming tkaemming deleted the absolute-count-search branch March 1, 2017 22:35
@ehfeng ehfeng removed the request for review from dcramer May 5, 2017 17:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: In saved searches, "at least X events" filter for the issues

3 participants