Permit almost anything for releases again #5022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macqueen
approved these changes
Mar 2, 2017
Sija
reviewed
Mar 3, 2017
| from sentry.utils.apidocs import scenario, attach_scenarios | ||
|
|
||
|
|
||
| BAD_RELEASE_CHARS = '\n\f\t/' |
Contributor
There was a problem hiding this comment.
there is many other special chars like \r or \0, why not use proper regex allowing only the ones in ASCII range?
mattrobenolt
pushed a commit
that referenced
this pull request
Mar 6, 2017
Permit almost anything for releases again
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the old regex was malformed so we permitted nearly anything. This
does the same now again.