Abstract out SimpleThreadedWorkerPool from RiakClient.
#5499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isolates out the worker pool logic from the Riak client itself so that its behavior is easier to understand. The primary side effect of this change is that it causes the thread pool to be set up when the first job is submitted, which should prevent a deadlock that would manifest itself when the Riak client was instantiated in the parent process of a multi-process environment. This also makes some other minor changes for the sake of readability (e.g. using `partial` rather than binding `key` and `event` to callback function as default arguments, and unpacking the tuple argument provided to `SimpleThreadedWorkerPool.submit` to ensure it is the correct length.) This also fixes the same issue as GH-5411 (since otherwise it would conflict.)
Contributor
Author
|
I'm not sure if there are any tests that specifically cover these paths (eek) but I did test this against a local Riak to ensure I didn't break anything in the move. I'm fairly confident this fixes the deadlock issue (ask me for more details about that if you want them.) |
Contributor
Generated by 🚫 danger |
mattrobenolt
approved these changes
Jun 1, 2017
Contributor
mattrobenolt
left a comment
mattrobenolt
left a comment
There was a problem hiding this comment.
Yeah, I assume you actually ran this and it worked fine. Nothing seems wrong here.
tkaemming
added a commit
that referenced
this pull request
Jun 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isolates out the worker pool logic from the Riak client itself so
that its behavior is easier to understand.
The primary side effect of this change is that it causes the thread pool
to be set up when the first job is submitted, which should prevent a
deadlock that would manifest itself when the Riak client was
instantiated in the parent process of a multi-process environment.
This also makes some other minor changes for the sake of readability
(e.g. using
partialrather than bindingkeyandeventto callbackfunction as default arguments, and unpacking the tuple argument provided
to
SimpleThreadedWorkerPool.submitto ensure it is the correct length.)This also fixes the same issue as GH-5411 (since otherwise it would
conflict.)