Adds fsevents as optional dependency #5654
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should solve webpack using up 100% CPU on OSX. See webpack/webpack#701 Note fsevents is an OSX only package, but having it as an "optional" dependency means yarn will ignore build errors for the package.
dcramer
approved these changes
Jun 28, 2017
Member
Author
|
Closed from #5661 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve webpack using up 100% CPU on OSX.
See webpack/webpack#701
Note fsevents is an OSX only package, but having it as an "optional"
dependency means yarn will ignore build errors for the package.
/cc @dcramer