Skip to content

build: improve makefile usage + parallelism #5662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcramer merged 1 commit into from
Jun 30, 2017
Merged

build: improve makefile usage + parallelism #5662

dcramer merged 1 commit into from
Jun 30, 2017

Conversation

@dcramer
Copy link
Member

@dcramer dcramer commented Jun 29, 2017

Before:

time make develop
real	0m23.721s
user	0m16.093s
sys	0m7.922s

After:

time make develop
real	0m15.069s
user	0m18.554s
sys	0m8.496s

@ghost
Copy link

ghost commented Jun 29, 2017

1 Warning
⚠️ Changes to build requirements

Generated by 🚫 danger

mattrobenolt
mattrobenolt reviewed Jun 29, 2017
View reviewed changes
Makefile
@@ -1,13 +1,12 @@
CPUS ?= $(shell sysctl -n hw.ncpu || echo 1)
Copy link
Contributor

@mattrobenolt mattrobenolt Jun 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this only works on OSX. I think you'll break it in Travis. Or I guess just fall back to 1.

Copy link
Member Author

@dcramer dcramer Jun 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we could probably tweak it, but i was mostly focused on making it faster in dev

mattrobenolt
mattrobenolt approved these changes Jun 29, 2017
View reviewed changes
Copy link
Contributor

@mattrobenolt mattrobenolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@dcramer dcramer merged commit 37abaa3 into master Jun 30, 2017
@dcramer dcramer deleted the make/parallel branch June 30, 2017 00:03
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mattrobenolt mattrobenolt mattrobenolt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dcramer @mattrobenolt @evanpurkhiser