db: Remove JOIN between GroupTagKey and TagKey #6077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretthoerner
force-pushed
the
remove-grouptagkey-tagkey-join
branch
from
fca8159 to
a629fb8
Compare
dcramer
reviewed
Sep 8, 2017
|
|
||
| class GroupTagsEndpoint(GroupEndpoint): | ||
| def get(self, request, group): | ||
| grouptagkeys = list(GroupTagKey.objects.filter( |
Member
There was a problem hiding this comment.
yeah this won't work as it could be like a billion rows
Contributor
Author
There was a problem hiding this comment.
Is there a place off the top of your head where we already handle iterating across different DBs?
Member
There was a problem hiding this comment.
oh actually this is fine, grouptagkeys is limited to one group, sorry!
dcramer
approved these changes
Sep 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mattrobenolt This was the quick fix, but I guess a group could in theory have a shitload of
GroupTagKeys... do you think I need to batch/iterate?