feat: apitoken types to support prefixes #65684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Contributor
|
This PR has a migration; here is the generated SQL for --
-- Add field token_type to apitoken
--
ALTER TABLE "sentry_apitoken" ADD COLUMN "token_type" varchar(7) NULL; |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #65684 +/- ##
=======================================
Coverage 84.18% 84.19%
=======================================
Files 5271 5272 +1
Lines 235792 235802 +10
Branches 40810 40810
=======================================
+ Hits 198508 198523 +15
+ Misses 37065 37060 -5
Partials 219 219
|
markstory
approved these changes
Feb 23, 2024
Member
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
Schema change looks good to me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of getsentry/rfcs#32.
Add a nullable
token_typecolumn to theApiTokenmodel. This will be used to help us identify the different kinds of API tokens we have in the application via a prefix. With this, we'll be able to integrate with GitHub and others' secret scanning program to prevent token leaks. Legacy (e.g. tokens that already exist) will have a null value here, so we'll know they are not one of our new tokens with the prefix format once all tokens are stored solely as hashed values.