Skip to content

Conversation

@asottile-sentry
Copy link
Contributor

it has no effect in production so I'm removing it

it has no effect in production so I'm removing it
@asottile-sentry asottile-sentry requested a review from jan-auer May 17, 2024 09:10
@asottile-sentry asottile-sentry requested a review from a team as a code owner May 17, 2024 09:10
@asottile-sentry asottile-sentry requested a review from a team May 17, 2024 09:10
@asottile-sentry asottile-sentry enabled auto-merge (squash) May 17, 2024 09:10
@codecov
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.90%. Comparing base (5849309) to head (1ab1a66).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #71093   +/-   ##
=======================================
  Coverage   77.89%   77.90%           
=======================================
  Files        6522     6522           
  Lines      290576   290539   -37     
  Branches    50275    50265   -10     
=======================================
- Hits       226339   226335    -4     
+ Misses      57996    57960   -36     
- Partials     6241     6244    +3     

see 14 files with indirect coverage changes

@asottile-sentry asottile-sentry merged commit 3ecef85 into master May 17, 2024
@asottile-sentry asottile-sentry deleted the asottile-canonical-dict-in-tests branch May 17, 2024 09:54
cmanallen pushed a commit that referenced this pull request May 21, 2024
it has no effect in production so I'm removing it

<!-- Describe your PR here. -->
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants