ref: rework build to be reusable outside of setup.py #71098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #71098 +/- ##
=======================================
Coverage 77.89% 77.90%
=======================================
Files 6522 6522
Lines 290576 290539 -37
Branches 50275 50265 -10
=======================================
- Hits 226339 226338 -1
+ Misses 57996 57956 -40
- Partials 6241 6245 +4 |
IanWoodard
approved these changes
May 17, 2024
| // this is the path to the django "sentry" app, we output the webpack build here to `dist` | ||
| // so that `django collectstatic` and so that we can serve the post-webpack bundles | ||
| const sentryDjangoAppPath = path.join(__dirname, 'src/sentry/static/sentry'); | ||
| const distPath = env.SENTRY_STATIC_DIST_PATH || path.join(sentryDjangoAppPath, 'dist'); |
Member
There was a problem hiding this comment.
Was this environment variable never used?
Contributor
Author
There was a problem hiding this comment.
it was only ever set to exactly the same value as this
Comment on lines
+32
to
+33
| parser = argparse.ArgumentParser() | ||
| parser.parse_args() |
Member
There was a problem hiding this comment.
Are we planning to make use of this in the future?
Contributor
Author
There was a problem hiding this comment.
it's mostly so thing --help doesn't make it just do it -- even though there's no options
cmanallen
pushed a commit
that referenced
this pull request
May 21, 2024
need to get off setuptools so we can get to python 3.12 -- and so we can conditionally do the js build only for self-hosted (since we do it twice for getsentry for no reason!) <!-- Describe your PR here. -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need to get off setuptools so we can get to python 3.12 -- and so we can conditionally do the js build only for self-hosted (since we do it twice for getsentry for no reason!)