From 920ceb98b7341c74a60065300b2658c5b360f114 Mon Sep 17 00:00:00 2001 From: JonasBa Date: Tue, 21 May 2024 12:20:29 -0400 Subject: [PATCH] feat(profiling): enable charts if values are sent --- .../profiling/flamegraph/flamegraph.tsx | 22 ++++++++++++++----- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/static/app/components/profiling/flamegraph/flamegraph.tsx b/static/app/components/profiling/flamegraph/flamegraph.tsx index d0717d683388..e37cc842daf4 100644 --- a/static/app/components/profiling/flamegraph/flamegraph.tsx +++ b/static/app/components/profiling/flamegraph/flamegraph.tsx @@ -240,18 +240,28 @@ function Flamegraph(): ReactElement { const hasBatteryChart = useMemo(() => { const platform = profileGroup.metadata.platform; - return platform === 'cocoa'; - }, [profileGroup.metadata.platform]); + return platform === 'cocoa' || profileGroup.measurements?.cpu_energy_usage; + }, [profileGroup.metadata.platform, profileGroup.measurements]); const hasCPUChart = useMemo(() => { const platform = profileGroup.metadata.platform; - return platform === 'cocoa' || platform === 'android' || platform === 'node'; - }, [profileGroup.metadata.platform]); + return ( + platform === 'cocoa' || + platform === 'android' || + platform === 'node' || + profileGroup.measurements?.cpu_usage + ); + }, [profileGroup.metadata.platform, profileGroup.measurements]); const hasMemoryChart = useMemo(() => { const platform = profileGroup.metadata.platform; - return platform === 'cocoa' || platform === 'android' || platform === 'node'; - }, [profileGroup.metadata.platform]); + return ( + platform === 'cocoa' || + platform === 'android' || + platform === 'node' || + profileGroup.measurements?.memory_footprint + ); + }, [profileGroup.metadata.platform, profileGroup.measurements]); const profile = useMemo(() => { return profileGroup.profiles.find(p => p.threadId === threadId);