feat(dashboards): Adds public api docs for post and get /dashboards #74404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #74404 +/- ##
==========================================
+ Coverage 78.10% 78.23% +0.12%
==========================================
Files 6757 6685 -72
Lines 301551 299878 -1673
Branches 51888 51623 -265
==========================================
- Hits 235533 234605 -928
+ Misses 59680 58930 -750
- Partials 6338 6343 +5
|
| parameters=[GlobalParams.ORG_ID_OR_SLUG], | ||
| request=None, | ||
| responses={ | ||
| 200: inline_sentry_response_serializer( |
Contributor
Author
There was a problem hiding this comment.
I couldn't figure out a way to extend DashboardListSerializer to a list, so I created DashboardListResponse instead, and also typed DashboardListSerializer to use DashboardListResponse.
Member
sentaur-athena
left a comment
sentaur-athena
left a comment
There was a problem hiding this comment.
For easier review, you can follow these steps and see how your published API looks like in docs: https://develop.sentry.dev/application/api/public/#building-and-testing-locally
…thub.com:getsentry/sentry into egou/feat/dashboards-get-and-create-api-docs
Base automatically changed from
nar/feat/api-document-dashboard-details-endpoint
to
master
July 24, 2024 15:10
…ashboards-get-and-create-api-docs
….com:getsentry/sentry into egou/feat/dashboards-get-and-create-api-docs
edwardgou-sentry
deleted the
egou/feat/dashboards-get-and-create-api-docs
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents the dashboards endpoint and makes GET and POST methods public API.