ref(seer grouping): Stop using projects:similarity-embeddings-metadata flag
#74914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
JoshFerge
approved these changes
Jul 24, 2024
lobsterkatie
force-pushed
the
kmclb-remove-flag-check-when-processing-seer-results
branch
from
e0041a9 to
5c99698
Compare
lobsterkatie
changed the title
projects:similarity-embeddings-metadata flag
lobsterkatie
deleted the
kmclb-remove-flag-check-when-processing-seer-results
branch
JoshFerge
approved these changes
Jul 25, 2024
Christinarlong
pushed a commit
that referenced
this pull request
Jul 26, 2024
…ta` flag (#74914) When we first started working on the Seer grouping project, we were making a distiction between storing Seer results as metadata and using those results for grouping. The idea was to use storing but not using the results could serve as a way to do a dry run of the feature. In the meantime, however, we've gotten rid of that distinction, and now both flags (`projects:similarity-embeddings-metadata` and `projects:similarity-embeddings-grouping`) check the same enablement list. We can therefore stop checking the metadata flag and just check the grouping flag, with an eye to eventually removing the metadata flag all together. This does that, and includes the following changes: - Stop checking the metdata flag as part of `should_call_seer_for_grouping`. - Stop checking the grouping flag as part of `get_seer_similar_issues`, as now we'll only call it if we already know the flag is on. - Remove any tests testing behavior when the two flags have different values. - Fix a test (`test_sends_expected_data_to_seer`) which had a bug that the flag check in `get_seer_similar_issues` was hiding.
lobsterkatie
added a commit
that referenced
this pull request
Jul 29, 2024
This removes the `projects:similarity-embeddings-metadata` flag, which we no longer use[1] and whose feature handler has also been removed[2], and the `seer.similarity-embeddings-metadata-killswitch.enabled` option, which we've never actually used. [1] #74914 [2] getsentry/getsentry#14743
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we first started working on the Seer grouping project, we were making a distiction between storing Seer results as metadata and using those results for grouping. The idea was to use storing but not using the results could serve as a way to do a dry run of the feature.
In the meantime, however, we've gotten rid of that distinction, and now both flags (
projects:similarity-embeddings-metadataandprojects:similarity-embeddings-grouping) check the same enablement list. We can therefore stop checking the metadata flag and just check the grouping flag, with an eye to eventually removing the metadata flag all together. This does that, and includes the following changes:should_call_seer_for_grouping.get_seer_similar_issues, as now we'll only call it if we already know the flag is on.test_sends_expected_data_to_seer) which had a bug that the flag check inget_seer_similar_issueswas hiding.