chore(seer grouping): Remove metadata flag and killswitch #75016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
JoshFerge
approved these changes
Jul 25, 2024
lobsterkatie
force-pushed
the
kmclb-remove-seer-metadata-flag-and-killswitch
branch
from
c7b764e to
ca663f0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #75016 +/- ##
=======================================
Coverage 78.12% 78.12%
=======================================
Files 6748 6748
Lines 301180 301178 -2
Branches 51825 51825
=======================================
+ Hits 235298 235302 +4
+ Misses 59558 59551 -7
- Partials 6324 6325 +1
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
projects:similarity-embeddings-metadataflag, which we no longer use and whose feature handler has also been removed, and theseer.similarity-embeddings-metadata-killswitch.enabledoption, which we've never actually used.