ref(metrics): Replace SmartSearch with SearchQueryBuilder component #75221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 678 bytes ⬆️
|
priscilawebdev
commented
Jul 30, 2024
| ...props | ||
| }: MetricSearchBarProps) { | ||
| const org = useOrganization(); | ||
| const organization = useOrganization(); |
Member
Author
There was a problem hiding this comment.
minor change, please let me know if it is ok to introduce this here
shellmayr
approved these changes
Jul 30, 2024
Member
shellmayr
left a comment
shellmayr
left a comment
There was a problem hiding this comment.
From a usage perspective: LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR was initially reverted because the onChange event was firing too frequently in our main organization compared to our test organization. However, with the fix now merged, everything looks good.
Screen.Recording.2024-07-30.at.11.39.12.mov
Note