feat(insights): add view trends button in frontend domain view #78520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
This was referenced Oct 3, 2024
Bundle ReportChanges will increase total bundle size by 1.51kB (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
mjq
approved these changes
Oct 4, 2024
DominikB2014
added a commit
that referenced
this pull request
Oct 18, 2024
Work for (#77572) Similar to #78520 Adds a view trends button for the ai view and performs some related changes that were necessary for it to work <img width="1281" alt="image" src="https://github.com/user-attachments/assets/13b4c964-d2e1-4f2b-ba76-7357565e4eb3">
harshithadurai
pushed a commit
that referenced
this pull request
Oct 19, 2024
Work for (#77572) Similar to #78520 Adds a view trends button for the ai view and performs some related changes that were necessary for it to work <img width="1281" alt="image" src="https://github.com/user-attachments/assets/13b4c964-d2e1-4f2b-ba76-7357565e4eb3">
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for (#77572)
Adds a "view trends" button at the top right of the frontend domain overview page
This will be repeated for all domain views. (Also yes, we are looking into sharing a lot of these header stuff eventually).
I had to move the
<layout.header>up into theFrontendHeadercomponent, otherwise the button wouldn't be properly positioned (because<Layout.HeaderActions>wouldn't be a direct child of<Layout.Header>