Skip to content

Conversation

@DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Oct 3, 2024

Work for (#77572)
Similiar to #78520

Adds a view trends button for the mobile view and performs some related changes that were necessary for it to work
image

@DominikB2014 DominikB2014 requested a review from a team October 3, 2024 15:11
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 3, 2024
@DominikB2014 DominikB2014 requested review from a team and markushi and removed request for a team October 3, 2024 15:11
@codecov
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tic/app/views/insights/common/viewTrendsButton.tsx 0.00% 9 Missing ⚠️
...p/views/insights/pages/mobile/mobilePageHeader.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #78552      +/-   ##
==========================================
- Coverage   78.12%   78.11%   -0.01%     
==========================================
  Files        7086     7087       +1     
  Lines      312480   312496      +16     
  Branches    51040    51042       +2     
==========================================
+ Hits       244112   244116       +4     
- Misses      62004    62016      +12     
  Partials     6364     6364              

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DominikB2014 DominikB2014 merged commit d2a6968 into master Oct 4, 2024
@DominikB2014 DominikB2014 deleted the DominikB2014/mobile-trends-button branch October 4, 2024 13:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants