Skip to content

Conversation

@DominikB2014
Copy link
Contributor

Work for (#77572)
Similar to #78520

Adds a view trends button for the ai view and performs some related changes that were necessary for it to work
image

@DominikB2014 DominikB2014 requested a review from a team October 4, 2024 15:06
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 4, 2024
@codecov
Copy link

codecov bot commented Oct 4, 2024

Bundle Report

Changes will increase total bundle size by 1.28kB (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 30.98MB 1.28kB (0.0%) ⬆️

@codecov
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #78611       +/-   ##
===========================================
+ Coverage   52.16%   78.22%   +26.05%     
===========================================
  Files        7079     7104       +25     
  Lines      311665   312869     +1204     
  Branches    50904    51084      +180     
===========================================
+ Hits       162591   244729    +82138     
+ Misses     147549    61770    -85779     
- Partials     1525     6370     +4845     

Copy link
Contributor

@0Calories 0Calories left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to eventually have these trends buttons filter transactions based on the domain they were clicked from?

@DominikB2014
Copy link
Contributor Author

Are we going to eventually have these trends buttons filter transactions based on the domain they were clicked from?

Yup, if its possible, that's the plan. I think whatever filters are applied to the transaction table, will be applied once you click the view trends button.

@DominikB2014 DominikB2014 merged commit 508b223 into master Oct 18, 2024
44 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/view-trends-button-ai branch October 18, 2024 20:29
harshithadurai pushed a commit that referenced this pull request Oct 19, 2024
Work for (#77572)
Similar to #78520

Adds a view trends button for the ai view and performs some related
changes that were necessary for it to work
<img width="1281" alt="image"
src="https://github.com/user-attachments/assets/13b4c964-d2e1-4f2b-ba76-7357565e4eb3">
jan-auer added a commit that referenced this pull request Oct 21, 2024
* master: (288 commits)
  feat(metrics): Register MRI for spans/count_per_root_project (#78992)
  feat(dynamic-sampling): Settings for sample rate (#79341)
  Revert "feat(sentry-sdk): Enable HTTP2 transport" (#79391)
  fix(feedback): keep oldest date_added for duplicate user reports (#79387)
  chore(issue-stream): Remove tooltip for Unhandled (#79385)
  chore(autofix): Show banner if gen AI consent is given, even if no feature flag (#79362)
  chore(autofix+copilot) Allow autofix without FF if gen AI consent given (#79361)
  Fixes VULN-50 by enforcing option (#79384)
  perf(issues): improve adjacent_events query (#79365)
  feat(issues): Add anchor links back to issue sections (#79333)
  fix(issue-views): Make tab bar take up entire row (#79383)
  chore(issues): Add additional metrics for ownership matching (#79302)
  feat(insights): create screen rendering module (#79192)
  fix(issues): Avoid streamline issue layout rerenders (#79327)
  ref(performance): Add missing types to performance widgets (#79301)
  chore(issue-views): Add translation wrapper to aria label (#79320)
  chore(issue-stream): Reduce font size of title and message (#79378)
  feat(insights): update headers and breadcrumbs on frontend domain view (#78945)
  feat(insights): add view trends button to ai overview (#78611)
  ref(rr6): Remove unused param (#79379)
  ...
cmanallen pushed a commit that referenced this pull request Oct 23, 2024
Work for (#77572)
Similar to #78520

Adds a view trends button for the ai view and performs some related
changes that were necessary for it to work
<img width="1281" alt="image"
src="https://github.com/user-attachments/assets/13b4c964-d2e1-4f2b-ba76-7357565e4eb3">
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants