fix(dashboards): stricter permission check when dashboards cover all/my projects #78615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #78615 +/- ##
==========================================
- Coverage 78.14% 78.14% -0.01%
==========================================
Files 7099 7100 +1
Lines 312836 312695 -141
Branches 51085 51072 -13
==========================================
- Hits 244481 244364 -117
+ Misses 61975 61963 -12
+ Partials 6380 6368 -12 |
Co-authored-by: George Gritsouk <989898+gggritso@users.noreply.github.com>
oioki
added a commit
that referenced
this pull request
Oct 10, 2024
…l/my projects (#78830) Similar to #78615 When Open Membership is disabled, it is expected to have more granular access to certain objects that are associated with projects. First version of project-level access on saved queries was implemented in #72159 However, saved queries that cover "All Projects" or "My Projects" do not have explicit project ids, therefore we need to do a different check. After this PR, we will allow access to such saved queries only in these cases: * if Open Membership is enabled; * if actor is a Manager/Owner (having `org:write` scope); * if actor is the original creator of a saved query.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Open Membership is disabled, it is expected to have more granular access to certain objects that are associated with projects. First version of project-level access on dashboards was implemented in #70228
However, dashboards that cover "All Projects" or "My Projects" do not have explicit project ids, therefore we need to do a different check. After this PR, we will allow access to such dashboards only in these cases:
org:writescope);