Skip to content

Conversation

@DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Oct 10, 2024

Work for #77572

Similar to #78948

This PR updates all of frontend domain view and modules so that they contain the correct header titles and breadcrumbs.

@DominikB2014 DominikB2014 requested a review from a team October 10, 2024 16:12
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 10, 2024
@codecov
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../insights/browser/webVitals/views/pageOverview.tsx 14.28% 6 Missing ⚠️
...ews/insights/pages/frontend/frontendPageHeader.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #78945      +/-   ##
==========================================
- Coverage   78.28%   78.28%   -0.01%     
==========================================
  Files        7121     7123       +2     
  Lines      313525   313537      +12     
  Branches    51176    51176              
==========================================
+ Hits       245445   245452       +7     
- Misses      61650    61655       +5     
  Partials     6430     6430              

DominikB2014 added a commit that referenced this pull request Oct 16, 2024
…ew (#78951)

Work for #77572

Ensures all headers and breadcrumbs are correct within modules on
backend domain view.
Identical to #78945
But for mobile and ai (they are small so did them together)
DominikB2014 added a commit that referenced this pull request Oct 17, 2024
…#78948)

Work for #77572

Ensures all headers and breadcrumbs are correct within modules on
backend domain view.
Identical to #78945 
But for backend
@DominikB2014 DominikB2014 enabled auto-merge (squash) October 18, 2024 20:21
@DominikB2014 DominikB2014 merged commit dc07371 into master Oct 18, 2024
43 of 44 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/update-header-titles branch October 18, 2024 20:31
harshithadurai pushed a commit that referenced this pull request Oct 19, 2024
#78945)

Work for #77572

Similar to #78948 

This PR updates all of frontend domain view and modules so that they
contain the correct header titles and breadcrumbs.
jan-auer added a commit that referenced this pull request Oct 21, 2024
* master: (288 commits)
  feat(metrics): Register MRI for spans/count_per_root_project (#78992)
  feat(dynamic-sampling): Settings for sample rate (#79341)
  Revert "feat(sentry-sdk): Enable HTTP2 transport" (#79391)
  fix(feedback): keep oldest date_added for duplicate user reports (#79387)
  chore(issue-stream): Remove tooltip for Unhandled (#79385)
  chore(autofix): Show banner if gen AI consent is given, even if no feature flag (#79362)
  chore(autofix+copilot) Allow autofix without FF if gen AI consent given (#79361)
  Fixes VULN-50 by enforcing option (#79384)
  perf(issues): improve adjacent_events query (#79365)
  feat(issues): Add anchor links back to issue sections (#79333)
  fix(issue-views): Make tab bar take up entire row (#79383)
  chore(issues): Add additional metrics for ownership matching (#79302)
  feat(insights): create screen rendering module (#79192)
  fix(issues): Avoid streamline issue layout rerenders (#79327)
  ref(performance): Add missing types to performance widgets (#79301)
  chore(issue-views): Add translation wrapper to aria label (#79320)
  chore(issue-stream): Reduce font size of title and message (#79378)
  feat(insights): update headers and breadcrumbs on frontend domain view (#78945)
  feat(insights): add view trends button to ai overview (#78611)
  ref(rr6): Remove unused param (#79379)
  ...
cmanallen pushed a commit that referenced this pull request Oct 23, 2024
…ew (#78951)

Work for #77572

Ensures all headers and breadcrumbs are correct within modules on
backend domain view.
Identical to #78945
But for mobile and ai (they are small so did them together)
cmanallen pushed a commit that referenced this pull request Oct 23, 2024
…#78948)

Work for #77572

Ensures all headers and breadcrumbs are correct within modules on
backend domain view.
Identical to #78945 
But for backend
cmanallen pushed a commit that referenced this pull request Oct 23, 2024
#78945)

Work for #77572

Similar to #78948 

This PR updates all of frontend domain view and modules so that they
contain the correct header titles and breadcrumbs.
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants